Skip to content

Use real browsers instead of phantomjs #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use real browsers instead of phantomjs #54

wants to merge 3 commits into from

Conversation

rahulcs
Copy link
Contributor

@rahulcs rahulcs commented Nov 13, 2017

No description provided.

@rahulcs
Copy link
Contributor Author

rahulcs commented Nov 13, 2017

@santosh1994 check this out. Repeatedly fails on Travis.

@santosh1994 santosh1994 mentioned this pull request Nov 13, 2017
Merged
@santosh1994
Copy link
Contributor

@rahulcs

  • facets specs is fixed in test(facets): fix failing facet specs #55
  • autoscroll specs are failing since the same window being reused in real browser tests
  • another random failure was happening earlier, but we weren't able to figure out through information available on error stacktrace. But looking into real browser failure it seems like jsonp issue.

@rahulcs rahulcs force-pushed the use-real-browsers-instead-of-phantomjs branch 2 times, most recently from 53b751a to bb076e8 Compare November 14, 2017 04:56
@rahulcs rahulcs force-pushed the use-real-browsers-instead-of-phantomjs branch from bb076e8 to 4c8aca6 Compare November 27, 2017 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahulcs @santosh1994